Hide DNS queries by default + provide a CLI flag to override this behaviour

[alex-bender]

Hello!
Thanks for such a good tool. I have a question/enhancement:
is it possible to ignore some connections in Utilization by connection window?
For example, all connections to 53 port.
Thanks

[imsnif]

Yes, I also find this very annoying. Especially since most of those requests come from bandwhich itself!
I was thinking of not displaying them, but that felt a little dishonest to the user. Do you have a suggestion of how we can handle this better?

[alex-bender]

There are plenty of options:

• specify the port to ignore as options $ bandwhich --ignore-inbound-port 53
• add some interactivity: add filtering capabilities to the tool, runtime. Meaning press "f" key to input filter to ignore processes by port/name/proto
• ...

[alex-bender]

Another thing to consider -- to have this list persistent, let's say, on the other tab. Because usually connection is to short so it's hard to track. But have the log of this could be helpful, with process name, exe path and ppid/pid, and of course ip:port. What do you think?

[imsnif]

The thing is, I don't like "common sense" configuration to be behind a flag. I'd much rather the tool "does the right thing" by default and has a flag for the more esoteric use case.

How about if we say that by default, bandwhich hides DNS queries (and indicates this on the bottom line... something like Press <SPACE> to pause. (DNS queries hidden) and then have a cli flag for cancelling that? I would imagine most users would not care about DNS queries, and those who do have a way of cancelling this behaviour. What do you think?

[alex-bender]

Seems like a good idea. Not sure about space bar, but the general approach is good.

[imsnif]

The space bar is already part of the app. :) I was indicating it in order to clarify where the message should be. Cool! So I'll accept contributions for this. I think it'll be a big improvement.

[alex-bender]

I can look for some help. Let me ask a guy.

[olehs0]

I'm learning rust lang and I'll try to investigate this issue. I'll notice, If it will be successfully.

[alex-bender]

@imsnif If you could guide olehs0, I can bet my shoe that he will manage to do that!

[imsnif]

Well, I would not want you to lose your shoe - that sounds uncomfortable! :)

Happily. Let me know if you have any questions @olehs0 .

[alex-bender]

Yeah, I would like to keep my pair together, haha. Thanks!

[olehs0]

@imsnif Hi! I've a little question for you. I try to modify this file src/os/lsof.rs but it seems nothing happened, I mean if I put syntax error or something like this then build is still working, could you please help me?

[imsnif]

Hey @olehs0, I'm guessing you're running linux? That module is only used for mac/freebsd. You can see that here: https://github.com/imsnif/bandwhich/blob/master/src/os/mod.rs#L4-L5

[olehs0]

@imsnif oh, yes, I see, thank you

[olehs0]

@imsnif please check the pr

[imsnif]

Will do @olehs0 ! I promise to get to it by this weekend max (busy few days, sorry!)

[imsnif]

This has been released as part of 0.13.0

@alex-bender - looks like you will get to keep your shoe. :) Thanks for this @olehs0 !

[alex-bender]

@imsnif thanks a lot! I like my shoe very much!
Glad this merged! It's a first contribution from Oleh, @olehs0 congrats!