Skip to content
This repository has been archived by the owner on Jul 20, 2022. It is now read-only.

Allow to filter countries by locale in the dialog #67

Closed
wants to merge 1 commit into from
Closed

Allow to filter countries by locale in the dialog #67

wants to merge 1 commit into from

Conversation

themobilecoder
Copy link
Contributor

@themobilecoder themobilecoder commented Apr 2, 2020

This commit is for letting the user search / filter a country in the dialog using the selected locale.

Fixes #62 and
Fixes #48

I added a flag in the constructor so that a user can still search using the original name in the country_codes json file.

@AhsanAyaz
Copy link

Thanks for the PR @themobilecoder .
@imtoori can you please merge this and release a new version. This is quite crucial for many apps who're using internationalization 🙂
Thanks.

@imtoori
Copy link
Owner

imtoori commented Apr 2, 2020

Thank you very much
I'll review it asap today

@themobilecoder
Copy link
Contributor Author

There could be a better solution than this commit as this is just a quick fix. This implementation always localise the whole of country_codes every time the dialog is shown.

@imtoori imtoori self-assigned this Apr 4, 2020
@imtoori
Copy link
Owner

imtoori commented Apr 4, 2020

I think filterByLocale is a bit "useless" in the sense that naturally the filter should be performed using locale. Don't you think so?

@imtoori
Copy link
Owner

imtoori commented Apr 4, 2020

#70
I think this is better, what do you think @themobilecoder ?

@AhsanAyaz
Copy link

@imtoori your PR looks good.

@imtoori imtoori closed this Apr 4, 2020
@themobilecoder
Copy link
Contributor Author

#70
I think this is better, what do you think @themobilecoder ?

I agree! Updating the search is better. Thanks @imtoori!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Country filter is not working properly Uniform special characters for search
3 participants