Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access violation is thrown when clients sends an empty packet #4

Closed
la-legende opened this issue Nov 9, 2020 · 3 comments
Closed

Access violation is thrown when clients sends an empty packet #4

la-legende opened this issue Nov 9, 2020 · 3 comments
Assignees
@imxeno
Labels
bug Something isn't working

Comments

@la-legende
Copy link

Client throws memory error when trying to send message that contains only "`" sign.
@imxeno
Copy link
Owner

imxeno commented Nov 10, 2020

It's probably an access violation that occurs while attempting to create a string from a char* which is a nullptr. I'll look into it in the evening.

@imxeno imxeno self-assigned this Nov 10, 2020
@imxeno imxeno added the bug Something isn't working label Nov 10, 2020
@imxeno
Copy link
Owner

imxeno commented Nov 10, 2020

image

@imxeno imxeno changed the title Memory error Access violation is thrown when clients sends an empty packet Nov 10, 2020
@imxeno
Copy link
Owner

imxeno commented Nov 10, 2020 •
edited
Loading

Fixed in 483883f.

@imxeno imxeno closed this as completed Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imxeno imxeno

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imxeno @la-legende