Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it seems to be different code from the app released in the App Store #26

Closed
shutosg opened this issue Apr 22, 2021 · 4 comments
Closed

Comments

@shutosg
Copy link

shutosg commented Apr 22, 2021

Hi, developer.

Thank you for releasing a great app and making the source code open!
But, it seems to be different code from the app released in the App Store.
I would like to learn by reading the source code of the released version.
Could you please update the repository?

Thanks.

@imxieyi
Copy link
Owner

imxieyi commented Apr 22, 2021

I had been keeping two versions in sync back in 2017. However, after someone took my code for waifu2x-mac and published it as a paid app on the App Store even without designing their own UI, I decided to stop updating this open source version. As an individual open source developer this is the most offensive thing to experience.

I'm not going to update this version as long as it is still working in the foreseeable future. However, I can tell you the major improvements in the App Store version. Specifically:

  • Use vImage to convert data format for Core ML. This significantly reduces CPU usage.
  • Also use vImage to process alpha channel.
  • Batch input via this API. This significantly speeds up process on ANE.

@shutosg
Copy link
Author

shutosg commented Apr 24, 2021

OMG... That's very unfortunate.
Okey, I understand and thank you for the info.
BTW, do you use any framework for fancy UI and animations?

@imxieyi
Copy link
Owner

imxieyi commented Apr 24, 2021

The new UI is mostly built on [SwiftUI](https://developer.apple.com/xcode/swiftui/.

@shutosg
Copy link
Author

shutosg commented Apr 25, 2021

SwiftUI!
I see, thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants