Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Custom ESRGAN models #54

Closed
BuyMyMojo opened this issue Aug 6, 2022 · 9 comments
Closed

[Request] Custom ESRGAN models #54

BuyMyMojo opened this issue Aug 6, 2022 · 9 comments

Comments

@BuyMyMojo
Copy link

An option to choose a custom .pth model file for ESRGAN would be helpful, like being able to use the general Siax model or NMKD’s Jaywreck3 models.

Large collection of models: https://upscale.wiki/wiki/Model_Database

@imxieyi
Copy link
Owner

imxieyi commented Aug 6, 2022

This is already on my radar. Probably supporting custom Core ML models makes more sense because it can support ANE which runs way faster than GPU with only slight sacrifice in quality.

@BuyMyMojo
Copy link
Author

I don't have any experince with Core ML, will transitioning those odels be relatively simple or will we need entire new models?

@imxieyi
Copy link
Owner

imxieyi commented Aug 6, 2022

Converting PyTorch (.pth) models to Core ML is relatively simple using coremltools. It requires basic understanding of ML frameworks though.

@BuyMyMojo
Copy link
Author

Great, whenever the custom model support drops I'll start trying to convert some! Thanks a bunch

@BuyMyMojo
Copy link
Author

Just gonna link the example documentation page here for anyone else that will look here: https://coremltools.readme.io/docs/pytorch-conversion

@imxieyi
Copy link
Owner

imxieyi commented Feb 19, 2023

The update to add custom models support is almost done, as well as a conversion script that supports most models from upscale.wiki. Would you like to help with beta testing?

If so please send your Apple ID to support@waifu2x.app so that I can add you to a TestFlight beta version. Thanks in advance.

@BuyMyMojo
Copy link
Author

Yes I would love to :)

@imxieyi
Copy link
Owner

imxieyi commented Mar 4, 2023

Close as the custom models feature has been released now.

@imxieyi imxieyi closed this as completed Mar 4, 2023
@imxieyi
Copy link
Owner

imxieyi commented Mar 4, 2023

Close as the custom models feature has been released now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants