Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images of Size Smaller than Model Input Cause Crash #17

Closed
KurumiSerori opened this issue Jan 11, 2020 · 8 comments
Closed

Images of Size Smaller than Model Input Cause Crash #17

KurumiSerori opened this issue Jan 11, 2020 · 8 comments

Comments

@KurumiSerori
Copy link

Seems unable to process pictures on Catalina, neither App or CLI version.

@imxieyi
Copy link
Owner

imxieyi commented Jan 12, 2020

Tried the latest one in Releases on 10.15.2 and it works fine. Tried to compile from source using Xcode 11.3 and it also works. Are you copying or linking to binary out of the bundle?

@KurumiSerori
Copy link
Author

Hi there, I'm using Xcode 11.3 and the automatic script to build the app. I'm using symbolic link on the binary.
The app can launch until I hit the process button. Both app and CLI gives me an 'Illegal instruction: 4' signal.

The crash report of app can be found at Ubuntu Paste.
I'm inexperienced with MacOS coding, hope this can help.

@imxieyi
Copy link
Owner

imxieyi commented Jan 21, 2020

Did you try building from Xcode? Just try Option B. Also, please try pre-built package from releases.

@KurumiSerori
Copy link
Author

I have tried to build the app from Xcode and also tested the pre-released version, this crash still exists.
I followed the crash report and try to locate the problem, I think the app or cli tool always crash on this line of code in Waifu2x.in_pipeline within Waifu2x.run Module.

Xnip2020-01-28_20-33-05

@imxieyi
Copy link
Owner

imxieyi commented Jan 28, 2020

Does this happen on all images? It looks like an image-specific issue. Please try a larger image.

@KurumiSerori
Copy link
Author

You're right, seems the crash only occurs on small-sized images. The app works well with those larger ones.
As we have found the cause, I'm gonna closing this issue. Thanks for help.

@imxieyi
Copy link
Owner

imxieyi commented Jan 28, 2020

This is still a bug. Waifu2x-ios store version contains a fix for this. I will back port this fix when I have time.

@imxieyi imxieyi reopened this Jan 28, 2020
@imxieyi imxieyi changed the title Crashed on MacOS 10.15.2 Images of Size Smaller than Model Input Cause Crash Jan 28, 2020
@KurumiSerori
Copy link
Author

Fine, as your wish. 😉

@imxieyi imxieyi closed this as completed in e1f9397 Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants