Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Country could not be determined" warning if countryBasedOnIp not used #28

Open
Patta opened this issue Apr 6, 2021 · 1 comment · May be fixed by #36
Open

Remove "Country could not be determined" warning if countryBasedOnIp not used #28

Patta opened this issue Apr 6, 2021 · 1 comment · May be fixed by #36

Comments

@Patta
Copy link

Patta commented Apr 6, 2021

If the countryBasedOnIp configuration is set to *, e.g. to use only the browserLanguage detection, the exception like Tue, 06 Apr 2021 13:07:48 +0200 [WARNING] request="cae49e28ec7c0" component="In2code.Ipandlanguageredirect.Domain.Service.IpToCountry.LocalDatabase": Executing of class failed - ["Country could not be determined"] should be disabled, otherwise the warning is written on every page load to the log file.

Additional it would be cool to disable the ipToCountryService by e.g. choose "none" for ipToCountryService in the extension settings.
@einpraegsam
Copy link
Collaborator

ok, understand your problem. I like the none option that you mention. PR are always welcome :)

@Patta Patta linked a pull request Sep 16, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TASK] Change log level of IpToCountry service from warning to debug Patta/ipandlanguageredirect
2 participants
@einpraegsam @Patta