Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ganttchart #16

Merged
merged 13 commits into from Sep 5, 2019
Merged

Ganttchart #16

merged 13 commits into from Sep 5, 2019

Conversation

KevCaz
Copy link
Member

@KevCaz KevCaz commented Aug 17, 2019

  • add blendColors()
  • add ganttChart()
  • darken() and lighten() now support negative percentage by calling each other 🎨
  • many small changes have been done to follow good practice 🎨
  • close Ganttchart #16

@codecov-io
Copy link

codecov-io commented Aug 17, 2019

Codecov Report

Merging #16 into master will increase coverage by 3.42%.
The diff coverage is 36.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   32.45%   35.87%   +3.42%     
==========================================
  Files          39       41       +2     
  Lines         986     1062      +76     
==========================================
+ Hits          320      381      +61     
- Misses        666      681      +15
Impacted Files Coverage Δ
R/pointsInPolygon.R 100% <ø> (ø) ⬆️
R/prettyRange.R 100% <ø> (ø) ⬆️
R/contrastColors.R 95.83% <ø> (ø) ⬆️
R/zzz.R 0% <ø> (ø) ⬆️
R/mixColors.R 0% <0%> (ø)
R/translation.R 76.92% <0%> (ø) ⬆️
R/frameIt.R 0% <0%> (ø) ⬆️
R/image2.R 0% <0%> (ø) ⬆️
R/plotimage.R 0% <0%> (ø) ⬆️
R/polarPlot.R 0% <0%> (ø) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fd599e...e7c16a4. Read the comment docs.

Copy link
Collaborator

@david-beauchesne david-beauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gantt chart function is indeed more general and usable now than in the previous changes, good job. The usability was much more limited before. I would still, at some point, look into changing the date format on the x axis (e.g. in days, weeks, years), but for now this is pretty good!

@david-beauchesne david-beauchesne merged commit a879293 into master Sep 5, 2019
@KevCaz KevCaz mentioned this pull request Sep 5, 2019
@KevCaz KevCaz deleted the ganttchart branch April 21, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants