Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Fit" does not work #6

Open
MarkCallow opened this issue Oct 7, 2013 · 5 comments
Open

"Fit" does not work #6

MarkCallow opened this issue Oct 7, 2013 · 5 comments
Assignees
Labels

Comments

@MarkCallow
Copy link

Clicking "Fit" has no effect on the displayed image. It merely changes the button to "1:1". However if manually zoom in using the "scroll wheel" then click "1:1" the displayed image is resized to actual size. Clicking "Fit" still has no effect.

@jaytaoko
Copy link
Contributor

This issue is being addressed...

@jaytaoko
Copy link
Contributor

Sorry for the long time it took to address this issue...

The scale to "fit" and scale to "1:1" are now two different buttons in the interface. I think it should have been so from the start. with two separate buttons, there is no more ambiguity in the scale UI.

scalingbuttons

There's a new option to let the user decide if an image should be scaled to the fit the view or displayed with a one to one pixel to texel ratio when it is loaded for the first time.

scaleoption

These fixes will be released in the coming week. And more coming very soon...

@jaytaoko jaytaoko self-assigned this Feb 21, 2014
@jaytaoko
Copy link
Contributor

jaytaoko commented Mar 3, 2014

Pico Pixel 0.6.5 has been released. This issue should no longer apply. Please, let me know what you think of the solution.
Again, I am sorry for the long time it took to address this.
Regards

@MarkCallow
Copy link
Author

I tried 0.6.5. It seems mostly good but I noticed 2 things about mipmap display:

  • the option to display all the mipmaps stacked on top of each other seems to have disappeared
  • when 1:1 is selected and you shift-up-arrow through the mip levels, they are all shown at the size of the level that was displayed when the 1:1 button is clicked. This is especially a problem if you click the button when the 1x1 level is selected. I think the levels should be displayed at actual size when 1:1 is set.

@jaytaoko
Copy link
Contributor

jaytaoko commented Mar 5, 2014

Thank you very much for your feedbacks.

the option to display all the mipmaps stacked on top of each other seems to have disappeared

Yes, I said it here Pico Pixel 0.6.5, the feature has been cut but I didn't explain why. It was taking too much time to make the alternate view with all mipmap spread in a row to work. So I cut that feature and the one with all the mips stacked one of top of the other in order to make the release. However I will see to bring bring back the stacked mips in the next release.

when 1:1 is selected and you shift-up-arrow through the mip levels, they are all shown at the size of the level that was displayed when the 1:1 button is clicked. This is especially a problem if you click the button when the 1x1 level is selected. I think the levels should be displayed at actual size when 1:1 is set.

The 1:1 button performs a one time action which is to scale the current image/mip level to one to one pixel to texel ratio. Its effect does not persist over time or over the next mip level. The same goes for the "Fit" option.

One possible alternative is to use the shortkey 7 and 8 to respectively "Fit" the image to the view or scale it to a 1:1 pixel/texel ratio.

The design of the buttons in the tool bar will improve to better reflect the type of action they perform and their persistence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants