Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe flags were added and after that I cannot use Actomaton as a dependency #56

Closed
tiborkiss opened this issue Jun 7, 2022 · 4 comments

Comments

@tiborkiss
Copy link

Hi.

I played with Actomaton version 0.3.1 and I was happy with it.
Now I tried to upgrade to 0.6.0 and I get the following compilation error:
The package product 'ActomatonStore' cannot be used as a dependency of this target because it uses unsafe build flags.

The commit which introduced the change is this:
Add Sendable conformances, -warn-concurrency & -enable-actor-data-race-checks compiler options

To me this unsafe flags error seems confusing, like for the others.
If that unsafe flags are banned from the dependencies, what should we do? Is that absolutely necessary to add or there is a workaround setting into the project which depend on unsafe flagged packages?

@tiborkiss
Copy link
Author

I saw that in swiftui-hooks repo was the same issue, but they removed the unsafe flags.

@inamiy
Copy link
Member

inamiy commented Jun 8, 2022

Hi @tiborkiss 👋

Yes, there is a workaround that not specifying by git-tag but either by "branch name" or "git hash" will work.

See also: Question about "...contains unsafe build flags" in SPM - Development / Package Manager - Swift Forums

As current implementation heavily relies on Swift Concurrency checks for better safety,
I'm planning to keep its unsafeFlags as is until Swift 6 comes in place.

@tiborkiss
Copy link
Author

Thank you for the hint. Actually I tried 2 days ago, specifically to put the SHA instead of the tag. At that time didn't worked for me. Now I tried again and now it works. Perhaps some quirks, such as Reset Package Cache I forgot to do last time.
Luckily I tried again today.
Therefore I close this issue.

@inamiy
Copy link
Member

inamiy commented Jun 10, 2022

Added installation explanation in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants