This repository has been archived by the owner on Jul 13, 2022. It is now read-only.
Add usesTimeTravel flag
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problems mentioned in #14 (comment) , #15, and possibly #16 .
After investigation, the slowest task was not in
Stopwatchbut ratherTimeTravelwhere it collects all previous states as histories.With having a rapid event-flow, I discovered time-travelling will be the dominant cause of the UI glitches.
This can be simply solved by removing time-travelling feature.
In this PR,
usesTimeTravelis introduced so that one can easily testusesTimeTravel = falsecase, which is the normal non-debug configuration.