This repository has been archived by the owner on Dec 12, 2021. It is now read-only.
Add EffectMapping.makeInout
& rename Effect.none
to .empty
#14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
EffectMapping.makeInout
asinout
-based initializer for easier mapping implementation.But to achieve this,
EffectMapping.makeInout
argument's return type will haveOptional<Effect>
where current implementation hasEffect.none
withExpressibleByNilLiteral
which becomes ambiguous toOptional
, so I renamedEffect.none
to.empty
, and removedExpressibleByNilLiteral
.