This repository has been archived by the owner on Dec 12, 2021. It is now read-only.
Revert #13 where scheduler is applied to inputs that cause delayed UI rendering
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d UI rendering
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #12 #13
This PR reverts #13 where
scheduleris also applied to externalinputs.Unfortunately, this caused delayed UI rendering that becomes annoying especially in SwiftUI which uses synchronous UI binding update.
Since
inputs.receive(on: scheduler)is not a requirement for avoiding synchronous feedback crash (though it improves thread safety), this PR will applyscheduleronly foreffectInputs.Downside of this change is that user needs to be aware of thread-safety issue as commented in documentation:
But still, having
schedulerparameter is (probably) better than going back before #12 .