Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created_d1 isn't time zone agnostic like d1 is #74

Closed
kueda opened this issue May 31, 2017 · 1 comment
Closed

created_d1 isn't time zone agnostic like d1 is #74

kueda opened this issue May 31, 2017 · 1 comment

Comments

@kueda
Copy link
Member

kueda commented May 31, 2017

At https://github.com/inaturalist/iNaturalistAPI/blob/master/lib/controllers/v1/observations_controller.js#L547 we don't pass dateRangeFilter() a date field like we do when interpreting d1, which means requests like http://api.inaturalist.org/v1/observations?created_d1=2017-06-01 don't quite work the way you might think. Was this intentional, and if so, why? I can change this, but I want to make sure I'm not breaking something.

@pleary
Copy link
Member

pleary commented Jan 8, 2018

I don't think this was intentional - at least I can't think of a reason right now. I think it'd be OK to pass in created_at_details.date as a date field to dateRangeFilter

viatrix added a commit to viatrix/iNaturalistAPI that referenced this issue Jul 24, 2020
viatrix added a commit to viatrix/iNaturalistAPI that referenced this issue Jul 24, 2020
@kueda kueda closed this as completed in 306033f Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants