How to manage errors

[niconoe]

For example, currently client code can receive something like {'error': 'Cette observation n’existe plus.'}. as a return value from update_observation()...

So the client code should look for an 'error' key in each of the results (and I'm not sure the API is really consistent in that). So it seems it would be more pythonic and nicer to raise an exception (a very specific if possible, or general one like Error 500 otherwise) each time it's not Status=200.

[niconoe]

Just updated update_observation() so it raises a requests.HTTPError if status != 200.

If this approach is choosen:

• Update all other functions so they work the same
• Test this
• Document this

[peterdesmet]

Seems reasonable to provide as nice an error we can, given what the API consistently returns.

[JWCook]

I am going to go ahead and close this issue, and will make additional issues for more specific error-handling features.