New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-use "contrast weight matrix" from stato #305
Re-use "contrast weight matrix" from stato #305
Conversation
002184f
to
3a08074
Compare
STATO's definition is awkward but accurate. +1 for re-use. |
"a contrast weight matrix is a information content entity which holds a set of contrast weight, coefficient used in a weighting sum of means defining a contrast". Wow. I think @nicholst calling it just "awkward" is rather charitable. I, on the other hand, would just say that it makes no sense as written and they should be alerted to fix it. |
Well, the odd grammatical number issues were discussed but honestly I got lost and didn't follow up with the STATO folks. See the discussion at stato/#23, where it's noted that all STATO class labels have to be singular. I've added a new comment to that stato/#23 and hopefully we can get it cleaned up. It is the right concept, and it was originally added at our request, but between basing the definition on Wikipedia and shoe-horning it into the STATO world, it got mangled. |
I left a comment on the ISA-tools/stato#23, but did not try to work on the "information content" thing - It does not make much sense to me though. |
3a08074
to
dca23f6
Compare
@nicholst, @khelm, @jbpoline: I think it's important to note that the textual definition of stato:'contrast weight matrix' closely follows its logical definition:
Where each stato (and obo) term is separately defined:
|
(to replace nidm:ContrastWeights) Update script
dca23f6
to
df5c363
Compare
(Rebased on master). I am going to merge this update as I think discussions regarding the definition will be carried on at ISA-tools/stato#23. |
Re-use "contrast weight matrix" from stato
This is a proposal to re-use the term "contrast weight matrix" from STATO, in place of
nidm:ContrastWeights
.The STATO term was created following discussions at ISA-tools/stato#23 and is defined by "a contrast weight matrix is a information content entity which holds a set of contrast weight, coefficient used in a weighting sum of means defining a contrast".
How would you feel about this?