Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Light mode #9

Closed
inclinedadarsh opened this issue Oct 1, 2023 · 5 comments · Fixed by #18
Closed

[FEATURE REQUEST] Light mode #9

inclinedadarsh opened this issue Oct 1, 2023 · 5 comments · Fixed by #18
Assignees
Labels
enhancement New feature or request hacktoberfest

Comments

@inclinedadarsh
Copy link
Owner

No description provided.

@inclinedadarsh inclinedadarsh changed the title Light mode [FEATURE REQUEST] Light mode Oct 1, 2023
@inclinedadarsh inclinedadarsh added the enhancement New feature or request label Oct 1, 2023
@rjwignar
Copy link
Contributor

rjwignar commented Oct 16, 2023

I would like to work on this feature.
Please assign it to me.

@inclinedadarsh
Copy link
Owner Author

Go ahead @rjwignar
I have assigned this to you.

I'm here for any assistance you need.
Thank you for your interest!

@rjwignar
Copy link
Contributor

Thank you.
So far I've extended the UI to use light/dark mode according to the user's system preferences.
Right now I'm working on the light mode styling.
image

I should have a PR later today.

However, I'm not sure of the best way to proceed with the grid image for light mode:
image

I understand the white grid image is from @/assets/bg-grid.png, but I can't seem to modify the image color using code.
Do you know of a way to do this without adding a new image to the project?

@inclinedadarsh
Copy link
Owner Author

inclinedadarsh commented Oct 18, 2023

This is looking good @rjwignar

For the bg-grid.png, we can do 2 things, choose whichever option you like:

  1. Leave it for now & open a separate issue for that.
  2. I'll give you access to the Figma, you make a light-mode version of it and use it in the assets as well. Write logic to show respective versions when in light or dark mode.

@rjwignar
Copy link
Contributor

I can't guarantee if I can replicate the exact effect you have in the original, but I can try making a light-version of it using the figma and include it in my PR.

Then depending on how you like it we can keep it remove it from the PR.
If sharing the figma requires an email you can share it to this email address: rjwignarajah@myseneca.ca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
Development

Successfully merging a pull request may close this issue.

2 participants