Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixed google maps url for address field #294

Merged
merged 1 commit into from
May 24, 2024

Conversation

OwenMelbz
Copy link
Contributor

@OwenMelbz OwenMelbz commented May 24, 2024

No description provided.

@OwenMelbz OwenMelbz changed the title bug fixed google maps url bug fixed google maps url for address field May 24, 2024
Copy link

@trevorrd trevorrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks!

@tschoffelen tschoffelen merged commit 51f4001 into tschoffelen:master May 24, 2024
2 checks passed
Copy link

馃帀 This PR is included in version 3.4.1 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@OwenMelbz
Copy link
Contributor Author

OwenMelbz commented May 28, 2024

Great catch! Thanks!

Sorry, maybe not clear enough, but this PR still doesn't "fully" work without the other PR #293

Currently you cannot pass in address as the validation is wrong, it forces you to pass in a lat/lng right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants