Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the focus/hover styling with footer SVGs on mobile devices #156

Closed
cindyli opened this issue Apr 7, 2020 · 0 comments · Fixed by #157
Closed

Fix the focus/hover styling with footer SVGs on mobile devices #156

cindyli opened this issue Apr 7, 2020 · 0 comments · Fixed by #157
Assignees
@cindyli
Labels
bug Something isn't working
Projects
We Count Site 1.0.0
Milestone
1.0.0

Comments

@cindyli
Copy link
Contributor

cindyli commented Apr 7, 2020

Describe the bug

The focus/hover styling with footer SVGs is incorrect. This only happens on mobile devices but not on desktop.

To Reproduce

  1. Turn on responsive design mode using browsers developer tool;
  2. Access any page and go to footer;
  3. Hover or use tab key to focus on a SVG icon on the footer. These SVGs include: IDRC logo; OCADU logo, Canada logo;
  4. The styling looks like:

Screen Shot 2020-04-07 at 9 41 45 AM

Expected behavior

The hover/focus styling should look like:

Screen Shot 2020-04-07 at 10 01 50 AM

Screenshots

See above.
@cindyli cindyli added the bug Something isn't working label Apr 7, 2020
@cindyli cindyli added this to the 1.0.0 milestone Apr 7, 2020
@cindyli cindyli self-assigned this Apr 7, 2020
@cindyli cindyli added this to To do in We Count Site 1.0.0 via automation Apr 7, 2020
@cindyli cindyli mentioned this issue Apr 7, 2020
Merged
4 tasks
@cindyli cindyli changed the title Fix the focus/hover styling with footer SVGs on mobile Fix the focus/hover styling with footer SVGs on mobile devices Apr 7, 2020
We Count Site 1.0.0 automation moved this from To do to Done Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cindyli cindyli

Labels
bug Something isn't working
Projects
No open projects
We Count Site 1.0.0
  
Done
Milestone
1.0.0
1 participant
@cindyli