Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: generate page routes dynamically #91

Closed
greatislander opened this issue Mar 6, 2020 · 0 comments · Fixed by #104
Closed

API: generate page routes dynamically #91

greatislander opened this issue Mar 6, 2020 · 0 comments · Fixed by #104
Assignees
@cindyli @greatislander
Labels
enhancement New feature or request
Projects
We Count Site 1.0.0
Milestone
1.0.0

Comments

@greatislander
Copy link
Member

greatislander commented Mar 6, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.

Right now, each named page from the WordPress backend has a corresponding route (about.vue, tools.vue, inclusion-challenges.vue etc). This involves lots of duplication as all of these Vue files are identical.

Describe the solution you'd like

All pages except for the Home page (index.vue) should share a single template, under /_page/index.vue, and the routes should be generated from the WordPress API response for the pages endpoint: https://wecount.inclusivedesign.ca/wp-json/wp/v2/pages

Describe alternatives you've considered

Not applicable.

Additional context

Not applicable.
@greatislander greatislander added the enhancement New feature or request label Mar 6, 2020
@greatislander greatislander added this to the 1.0.0 milestone Mar 6, 2020
@greatislander greatislander self-assigned this Mar 6, 2020
@greatislander greatislander added this to To do in We Count Site 1.0.0 via automation Mar 6, 2020
@cindyli cindyli mentioned this issue Mar 13, 2020
Merged
4 tasks
@greatislander greatislander moved this from To do to In progress in We Count Site 1.0.0 Mar 13, 2020
We Count Site 1.0.0 automation moved this from In progress to Done Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cindyli cindyli

@greatislander greatislander

Labels
enhancement New feature or request
Projects
No open projects
We Count Site 1.0.0
  
Done
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Issue-91: Add dynamic routing to share one single template cindyli/wecount.inclusivedesign.ca
2 participants
@cindyli @greatislander