Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logfmt/json keys for msg/lvl/t are hard-coded #147

Closed
neilisaac opened this issue May 22, 2018 · 3 comments
Closed

logfmt/json keys for msg/lvl/t are hard-coded #147

neilisaac opened this issue May 22, 2018 · 3 comments

Comments

@neilisaac
Copy link

Some logging services (ex. LogDNA) only parse specific key names to parse the log level and message. It would be nice if these were user configurable.

Proposed enhancement implemented in #145

@ChrisHines
Copy link
Collaborator

Have you considered writing a Handler that sets the KeyNames of each Record? I believe that this approach does not require any code changes in this package to achieve your goal.

@neilisaac
Copy link
Author

Sounds like a good workaround, thanks @ChrisHines. Is this preferable over an interface change in the library?

@ChrisHines
Copy link
Collaborator

Yes, changing the interface would be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants