Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce syslog facility/severity support #37

Closed
sborsje opened this issue Dec 6, 2014 · 3 comments
Closed

Reintroduce syslog facility/severity support #37

sborsje opened this issue Dec 6, 2014 · 3 comments

Comments

@sborsje
Copy link

sborsje commented Dec 6, 2014

Currently it's not possible to configure which syslog facility the syslog handler will log from. This means that all logs will be logged from the "kern" facility, since this is the default within the stdlib syslog package. This is confusing, because "kern" should be used for kernel logging only.

I noticed that syslog priority configuration used to be supported in this library, but it was removed in commit 54d74c8. Could you maybe reintroduce this? If not, it might be a good idea to pick a better default.

@inconshreveable
Copy link
Owner

Gah! This is my fault for not understanding how the syslog package works. When I wrote that, I mistakenly assumed that the caller didn't need to pass in the priority, because the log level would be set by each call. I missed the fact that priority is both the log level and the facility. You're right, we need to bring back the ability to set the syslog facility when creating the handler.

@raphael
Copy link

raphael commented May 20, 2015

I'm hitting that same issue - is there more to it than reverting that commit?

@inconshreveable
Copy link
Owner

Reverted 54d74c8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants