Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem when using encoded url in request path #143

Closed
slorber opened this issue Jun 19, 2014 · 3 comments
Closed

Problem when using encoded url in request path #143

slorber opened this issue Jun 19, 2014 · 3 comments
Labels

Comments

@slorber
Copy link

slorber commented Jun 19, 2014

Hello,

When using:

ngrok                                                                                                                                                                         (Ctrl+C to quit)

Tunnel Status                 online                                                                                                                                                          
Version                       1.6/1.6                                                                                                                                                         
Forwarding                    http://stamplephonegap.ngrok.com -> 127.0.0.1:8000                                                                                                              
Forwarding                    https://stamplephonegap.ngrok.com -> 127.0.0.1:8000                                                                                                             
Web Interface                 127.0.0.1:4040                                                                                                                                                  
# Conn                        1                                                                                                                                                               
Avg Conn Time                 3.98ms  
GET https://stamplephonegap.ngrok.com/http%3A%2F%2Fwww.google.com

This actually redirects the call to:

GET 127.0.0.1:8000/http:/www.google.com

while I expected it to redirect to:

GET 127.0.0.1:8000/http%3A%2F%2Fwww.google.com

It seems the request path is decoded once forwarded instead of being kept encoded as expected.

I can see it in my local server logs:

Serving HTTP on 0.0.0.0 port 8000 ...
localhost - - [19/Jun/2014 17:44:26] code 404, message File not found
localhost - - [19/Jun/2014 17:44:26] "GET /http:/www.google.com HTTP/1.1" 404 -

Related to:
phonegap/connect-phonegap#51 (comment)

@inconshreveable
Copy link
Owner

Definitely a bug, possibly related to #76

Not sure exactly where the error is coming from. I'm going to have to dive deeper. Thanks for reporting this!

@inconshreveable
Copy link
Owner

could still be an issue, leaving this one open if anyone wants to take a look

@russorat
Copy link
Collaborator

russorat commented May 8, 2024

Thank you for opening this issue! As of April 2016, the ngrok service has permanently moved to https://ngrok.com/. To join the community and file bug reports or feature enhancements for the ngrok agent, please go to https://github.com/ngrok/ngrok.

This repository is no longer actively maintained and will be archived soon to reduce confusion with the latest ngrok versions. We thank you for the continued support of ngrok and look forward to seeing you over at ngrok.com and the ngrok Community Repo.

@russorat russorat closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants