Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a compelling need for the custom changelist template? #32

Open
andybak opened this issue Jun 21, 2015 · 1 comment
Open

Is there a compelling need for the custom changelist template? #32

andybak opened this issue Jun 21, 2015 · 1 comment

Comments

@andybak
Copy link

andybak commented Jun 21, 2015

The problem with overriding admin templates is that if I want to use your app alongside another one that also has a custom changelist template I'm a bit stuck. There's no nice way round this - I usually have to pick the one that makes the smallest change and copy those changes to a template in my own app so I can then extend the other app's template.

In the case of your app - it looks like all you do to the changelist, is add in some javascript and css. This could be accomplished less intrusively (whilst still allowing the current approach in situations where it isn't problematic).

This would also make it easier for OrderableAdmin to be used as a mixin rather than a replacement for ModelAdmin.

@meshy
Copy link
Collaborator

meshy commented Oct 6, 2015

Hi @andybak, thanks for the report, and sorry for the inconvenience caused.

Having had a quick look at the custom templates, I suspect you're right that templates are not the right solution. We may be able to use the class Media to provide the css and javascript.

I'd also like these templates removed as I'm worried about them slipping out of sync with django.

Ideally, I'd like to get front-end tests (#30) to really have confidence in this. It's not strictly necessary of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants