Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional complete allows jump back to another state if signalChannel/InternalChannel is not empty #282

Closed
longquanzheng opened this issue Jun 15, 2023 · 2 comments
Closed

Conditional complete allows jump back to another state if signalChannel/InternalChannel is not empty #282

longquanzheng opened this issue Jun 15, 2023 · 2 comments

Comments

@longquanzheng
Copy link
Contributor

longquanzheng commented Jun 15, 2023 •
edited

There could be racing condition that when state execute decides to complete because no messages to process from waitUntil, at the time that it's completing, there is a message coming on the way.

Allowing this gracefulComplete with a condition to move to another state will prevent losing the messages for processing.

Workaround today: let user code “lock” a Chanel using data attribute and then check the channel again after locking , before completing workflow
@longquanzheng
Copy link
Contributor Author

longquanzheng commented Jun 28, 2023 •
edited

Name: ConditionalForceComplete( InternalChannelNonEmptyCondition( "channelName", StateX.class ) )

@longquanzheng longquanzheng changed the title Graceful complete allows jump back to another state if signalChannel/InternalChannel is not empty Conditional complete allows jump back to another state if signalChannel/InternalChannel is not empty Jul 4, 2023
This was referenced Jul 4, 2023
Open
Open
Closed
Merged
@longquanzheng
Copy link
Contributor Author

indeedeng/iwf-java-sdk#178

@longquanzheng longquanzheng mentioned this issue Sep 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@longquanzheng