Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile handlebars templates #34

Closed
andrewfan opened this issue Aug 13, 2014 · 3 comments
Closed

compile handlebars templates #34

andrewfan opened this issue Aug 13, 2014 · 3 comments
Milestone

Comments

@andrewfan
Copy link

Ember-cli in production env does not include full version of handlebars. It does not include handlebars runtime so Ember.Handlebars.compile is not defined. So to make ember-components work in production we have to compile all templates.

@asaf
Copy link
Contributor

asaf commented Aug 15, 2014

Most templates are precompiled, I will ensure the templates compiled in runtime will be gone.

@wwwdata
Copy link

wwwdata commented Dec 16, 2014

any progress on that issue here? Or will it only be fixed in the new standalone versions of ember-component?

@asaf
Copy link
Contributor

asaf commented Dec 16, 2014

@wwwdata better fix per addon, can you please open a PR per project ? I guess it can be found easily by greping for Handlebars.compile

Thanks

@asaf asaf closed this as completed Dec 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants