Modal: do not use 'trigger' together with 'sendAction'

[andrewfan]

Looks like now we can pass hide option in modal component.
But component's open, close methods https://github.com/indexiatech/ember-components/blob/master/lib/modal/modal.coffee#L129 use trigger and sendAction together that will cause an error. I explain why:
trigger wants a reference to real function inside hide param.
sendAction wants a string with the name of method that we will be propagated.

I recommend to remove trigger call because using sendAction is the best practice http://emberjs.com/guides/components/sending-actions-from-components-to-your-application/

[hussasad]

I am facing the same issue. I tried handling the 'show' action, which is sent from inside the modal component's open method like this

{{#em-modal configName="bs" open-if=openModal show="showPopup"}}

but i get an error since the open method is calling a trigger with the same name (this.trigger('show') which is followed by this.sendAction('show',this) )

is there a solution for this?

[asaf]

Agreed.

[asaf]

I duplicated this issue in the modal addon: indexiatech/ember-idx-modal#3

closing here.