Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember-CLI 0.0.42 Issue #42

Closed
OleRoel opened this issue Aug 30, 2014 · 13 comments
Closed

Ember-CLI 0.0.42 Issue #42

OleRoel opened this issue Aug 30, 2014 · 13 comments

Comments

@OleRoel
Copy link

OleRoel commented Aug 30, 2014

After installing ember-components with 'npm install --save ember-cli-components' and building my project with 'ember build' I get the following exception:

Build failed.
Path or pattern "vendor/ember-components/vendor/ic-styled/main.js" did not match any files [string exception]

This doesn't happen after uninstalling ember-cli-components.

ember -v:
version: 0.0.42
node: 0.10.30
npm: 1.4.24

@michiel
Copy link

michiel commented Aug 30, 2014

In ember-cli 0.0.42 the directory for bower installs has changed from vendor/ to bower_components/ - references should be changed from vendor/ to bower_components/ in .bowerrc, Brocfile, etc

@OleRoel
Copy link
Author

OleRoel commented Sep 1, 2014

Changing lines 31-33 in index.js of ember-cli-components (https://github.com/indexiatech/ember-cli-components) fixed the problem for me:

    this.app.import('bower_components/ic-styled/main.js');
    this.app.import('bower_components/ember-utils/dist/globals/main.js');
    this.app.import('bower_components/ember-components/dist/globals/main.js');

(you find it under project-path/node_modules/ember-cli-components/index.js)

Just for reference, the original code is as follows:

    this.app.import('vendor/ember-components/vendor/ic-styled/main.js');
    this.app.import('vendor/ember-components/vendor/ember-utils/dist/globals/main.js');
    this.app.import('vendor/ember-components/dist/globals/main.js');

@asaf
Copy link
Contributor

asaf commented Sep 2, 2014

Ill update the cli package.

Thanks for the update.

@RyanHirsch
Copy link

When making the changes @OleRoel suggested, I still seemed to be having issues that were prepending vendor to some of the file paths.
Got the build to work by just replacing vendor with bower_components:

    this.app.import('bower_components/ember-components/bower_components/ic-styled/main.js');
    this.app.import('bower_components/ember-components/bower_components/ember-utils/dist/globals/main.js');
    this.app.import('bower_components/ember-components/dist/globals/main.js');

@apjacks
Copy link

apjacks commented Oct 2, 2014

Just as an FYI, this is still an issue. The fix suggested by OleRoel worked for me.

@jcope2013
Copy link

@OleRoel suggestion worked for me thanks, a gotcha for me was I had to install both the ember cli and bower package for it to work properly

@asaf
Copy link
Contributor

asaf commented Oct 30, 2014

Will refactor the ember-cli-components project to work with Ember-Cli 0.1.1 properly.

@dennismende
Copy link

Are there any news about it?

@jicksta
Copy link

jicksta commented Nov 8, 2014

+1 We've bumped into this issue as well. Would be great if we had an update or a recommended temporary fork.

@jackmatt2
Copy link

For me (ember-cli@0.1.4) the temporary fix was as follows:

node_modules/ember-cli-components/index.js

    this.app.import('vendor/ember-components/bower_components/ic-styled/main.js');
    this.app.import('vendor/ember-components/bower_components/ember-utils/dist/globals/main.js');
    this.app.import('vendor/ember-components/dist/globals/main.js');

The difference here I suppose is that I am pulling the addon into an existing addon project.

@asaf
Copy link
Contributor

asaf commented Dec 12, 2014

Guys,

I decided to split the code into ember addons per component,
This will make the usage of the component super easy by using npm and will also avoid blowing up your app size with unnecessary code of components that you don't use.

You can track the progress in issue #57

@asaf asaf closed this as completed Dec 12, 2014
@wwwdata
Copy link

wwwdata commented Dec 16, 2014

Good idea, but in the meantime, could you fix that in the non-splitted version as well? I tried the splitted modal package and ran into different bugs there, already opened and issue.

@asaf
Copy link
Contributor

asaf commented Dec 16, 2014

@wwwdata Why ? I prefer to fix the bugs per addon (fixed the dependencies tree in the Modal project)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants