Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two dependencies missing? #68

Closed
consideRatio opened this issue Dec 16, 2014 · 2 comments
Closed

Two dependencies missing? #68

consideRatio opened this issue Dec 16, 2014 · 2 comments

Comments

@consideRatio
Copy link

The ember-idx-forms modules package.json contains devDependencies of
"broccoli-merge-trees": "^0.2.1",
"broccoli-static-compiler": "^0.2.1",

But when i run the test-server command using ember-cli (ember s) inside MYPROJECT dir, i get the following error.

Error: Cannot find module 'broccoli-merge-trees'
at Object. (.../MYPROJECT/node_modules/ember-idx-forms/index.js:3:18)

It seems that ember-idx-forms needs broccoli-merge-trees as a dependency right? This is contained on line 3 and 4 in the index.js file:

var mergeTrees = require( 'broccoli-merge-trees' ),
pickFiles = require( 'broccoli-static-compiler' );


So, it should list those inside dependencies instead of devDependencies right?
I made a pull request as an attempt solve this here, I do not have a deep understanding of what this will result in since I'm a bit dazzled by everything works. #69


My quickfix for myself have been to add
"broccoli-merge-trees": "^0.2.1",
"broccoli-static-compiler": "^0.2.1",
to MYPROJECT/package.json's devDependecies.

@asaf
Copy link
Contributor

asaf commented Dec 16, 2014

This is all because of fontawesome, which is not really a mandatory but recommended only, I will remove the dependencies of these two addons.

@asaf asaf closed this as completed in b5611c8 Dec 16, 2014
@asaf
Copy link
Contributor

asaf commented Dec 16, 2014

Also released a minor version (0.5.1) for this change,

Please try again, I hope it's fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants