Add signal for checkin state changed #3161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You still need to actually send the signal ;) |
ThiefMaster
reviewed
Nov 21, 2017
| @@ -66,3 +66,8 @@ | |||
| If this signal returns ``True``, the user will not be able to download | |||
| their ticket. | |||
| """) | |||
|
|
|||
| registration_checkin_updated = _signals.signal('registration-checkin-updated', """ | |||
| Called when the checkin state of registration changes. The `sender` is the | |||
There was a problem hiding this comment.
of a registration
(same typo in registration_state_updated, feel free to fix it there too).
I'd also move your new signal below that one since they are kind of similar so I think it makes more sense to have it up there.
bpedersen2
force-pushed
the
checkin-signal
branch
from
2715fab
to
5bb750c
Compare
ThiefMaster
reviewed
Nov 21, 2017
| @@ -57,6 +57,7 @@ def _process_PATCH(self): | |||
|
|
|||
| if 'checked_in' in request.json: | |||
| self._registration.checked_in = bool(request.json['checked_in']) | |||
| signals.event.registration_checkin_updated(self._registration) | |||
There was a problem hiding this comment.
Did you test this? I don't think signals implement __call__ so you need to call .send() on them:
signals.event.registration_checkin_updated.send(self._registration)
|
Please add a CHANGES.rst entry (in the "Internal Changes" section): |
bpedersen2
force-pushed
the
checkin-signal
branch
from
5bb750c
to
d0c0e58
Compare
|
Fixed the missing send and added changelog. The signal now arrives in a simple test plugin |
ThiefMaster
approved these changes
Nov 22, 2017
CHANGES.rst
Outdated
| @@ -34,6 +34,9 @@ Internal Changes | |||
| the ``can_manage`` method whose ``role`` argument has been renamed to | |||
| ``permission`` (:issue:`3057`) | |||
|
|
|||
| - Add new ``registration_checkin_updated`` signal that can be used by | |||
There was a problem hiding this comment.
there shouldn't be an empty line before this one (see the structure of the rest of the file)
bpedersen2
force-pushed
the
checkin-signal
branch
from
d0c0e58
to
29df8e3
Compare
bpedersen2
force-pushed
the
checkin-signal
branch
from
29df8e3
to
4f26184
Compare
This signal can be used e.g. in a plugin to print badges or further material on demand at a check-in desk. See https://talk.getindico.io/t/print-on-registration-plugin/99 for the discussion.
This is emitted only for explict checkin/checkout actions via the request handlers, not for db-bound operations such as cloning an event wiht registrations.
ThiefMaster
force-pushed
the
checkin-signal
branch
from
4f26184
to
b93f600
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This signal can be used e.g. in a plugin to print badges or further
material on demand at a check-in desk.
See https://talk.getindico.io/t/print-on-registration-plugin/99 for
the discussion.