Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly check booking privileges on the server #3696

Closed
ThiefMaster opened this issue Dec 12, 2018 · 0 comments · Fixed by #3702
Closed

Properly check booking privileges on the server #3696

ThiefMaster opened this issue Dec 12, 2018 · 0 comments · Fixed by #3702
Assignees
Projects

Comments

@ThiefMaster
Copy link
Member

ThiefMaster commented Dec 12, 2018

This depends on #3591.

Currently we simply check for admin privs and if a room uses prebookings to determine what kind of booking someone can create.

Instead of that we should actually return this information from the server to have a single source of truth, especially since we need to perform the check again when actually creating the booking.

Client-side code should already be using room.canUserBook and room.canUserPrebook for this, so all that's needed on the client is fetching the data with an API call and updating the getAllRooms selector to get the information from the correct place instead of the current "simple" check mentioned above.

@ThiefMaster ThiefMaster created this issue from a note in Release 2.2 (2.2-alpha) Dec 12, 2018
@pferreir pferreir moved this from 2.2-alpha to In progress in Release 2.2 Jan 8, 2019
@ThiefMaster ThiefMaster mentioned this issue Jan 10, 2019
Release 2.2 automation moved this from In progress to Done Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 2.2
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant