Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make builds from release tarballs possible #5341

Closed
andriish opened this issue May 10, 2022 · 3 comments
Closed

Make builds from release tarballs possible #5341

andriish opened this issue May 10, 2022 · 3 comments

Comments

@andriish
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Building of indico wheels from the release sources is not possible.
The reason is the multiple calls to 'git' in the build scripts, i.e. the build scripts assume the build happens always in a git repository.

Describe the solution you'd like
Be able to build indico wheels from the sources.

Describe alternatives you've considered
There are two solutions: either to update build scripts or to include .git repository into the release tarballs. The second seems to be an easier solution.

Best regards,

Andrii

@ThiefMaster
Copy link
Member

ThiefMaster commented May 10, 2022

We do not provide sdist/release tarballs... those are repo snapshots github always shows for a release (and AFAIK that can't be disabled), they are not something that people should use.

The supported ways of building/installing releases are:

  • the pre-built wheels from PyPI - this is what we recommend anyone who doesn't need to make modifications
  • built from a git checkout (ideally using a release tag like v3.1.1, or the release's branch such as 3.1.x)

@andriish
Copy link
Contributor Author

Hi @ThiefMaster ,

actually, the repo snapshots are fine apart from some minor tweaks that disable any calls to 'git' commands.
I will have a look if one can make any sense out of that.

Best regards,

Andrii

@andriish
Copy link
Contributor Author

andriish commented Oct 5, 2022

I think this was done in #5514.

@andriish andriish closed this as completed Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants