Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor "author list" dialog #5588

Merged
merged 16 commits into from Feb 1, 2023

Conversation

duartegalvao
Copy link
Member

@duartegalvao duartegalvao commented Nov 29, 2022

This PR refactors all of the "author list" dialogs, now renamed to "email authors". This dialog is used in abstract, contribution, paper and session lists.

Progress:

  • Convert dialog to a React-SUI Modal
  • Fetch authors' data
  • Display authors' data
  • Implement sorting by column
  • Allow selecting authors
  • Add email button
  • Implement filters
  • Refactor authors list button implementation
  • Show success message in authors list modal
  • Use identifiers instead of IDs

@duartegalvao duartegalvao marked this pull request as ready for review December 2, 2022 14:44
@duartegalvao duartegalvao force-pushed the personlist-refactor branch 3 times, most recently from 1328821 to 603a683 Compare December 8, 2022 11:35
@duartegalvao duartegalvao marked this pull request as draft December 8, 2022 11:35
@duartegalvao duartegalvao force-pushed the personlist-refactor branch 7 times, most recently from 5e73a2f to 3b31c90 Compare December 14, 2022 16:48
@duartegalvao duartegalvao force-pushed the personlist-refactor branch 2 times, most recently from 74bf1fa to 2629458 Compare January 5, 2023 15:18
@duartegalvao duartegalvao marked this pull request as ready for review January 5, 2023 15:22
@ThiefMaster
Copy link
Member

Sorry, but this doesn't work properly yet :/

image
image

Sorting doesn't really work either - at least it seems to be case sensitive.

On a much more positive note, the "registered for the event" indicator is now correct while the previous one was incorrect.

I'm also getting some JS warnings:

Warning: Failed prop type: The prop persons[2].identifier is marked as required in PersonList, but its value is undefined.
Warning: Each child in a list should have a unique "key" prop.

PS: I rebased your branch to the latest master and fixed the rebase conflicts (luckily just minor things in Python imports).

@ThiefMaster ThiefMaster enabled auto-merge (squash) February 1, 2023 17:55
@ThiefMaster ThiefMaster added this to the v3.2 milestone Feb 1, 2023
@ThiefMaster ThiefMaster enabled auto-merge (squash) February 1, 2023 17:56
@ThiefMaster ThiefMaster merged commit c72d9e0 into indico:master Feb 1, 2023
@duartegalvao duartegalvao deleted the personlist-refactor branch February 7, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants