Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hAtom rel=bookmark backcompat only for classic roots #134

Closed
gRegorLove opened this issue Jul 7, 2017 · 0 comments
Closed

hAtom rel=bookmark backcompat only for classic roots #134

gRegorLove opened this issue Jul 7, 2017 · 0 comments

Comments

@gRegorLove
Copy link
Member

rel=bookmark should only be parsed as u-url in a classic root microformat. I discovered via snarfed/bridgy#758 (comment) that it's always parsing as u-url, even inside mf2 roots.

Sample HTML:

<div class="h-entry">
<p> <a href="/article" rel="bookmark" class="p-name">Title of Post</a> </p>
<div class="e-content"><p> This is the post </p> </div>
</div>

mf2py parse (correct):

{
 "items": [
  {
   "type": [
    "h-entry"
   ], 
   "properties": {
    "name": [
     "Title of Post"
    ], 
    "content": [
     {
      "value": " This is the post  ", 
      "html": "<p> This is the post </p> "
     }
    ]
   }
  }
 ], 
 "rels": {
  "bookmark": [
   "/article"
  ]
 }, 
 "rel-urls": {
  "/article": {
   "text": "Title of Post", 
   "rels": [
    "bookmark"
   ]
  }
 }
}

php-mf2 parse (incorrect)

{
    "items": [
        {
            "type": [
                "h-entry"
            ],
            "properties": {
                "name": [
                    "Title of Post"
                ],
                "url": [
                    "/article"
                ],
                "content": [
                    {
                        "html": "<p> This is the post </p> ",
                        "value": "This is the post"
                    }
                ]
            }
        }
    ],
    "rels": {
        "bookmark": [
            "/article"
        ]
    },
    "debug": {
        "package": "https://packagist.org/packages/mf2/mf2",
        "version": "v0.3.2",
        "note": [
            "This output was generated from the php-mf2 library available at https://github.com/indieweb/php-mf2",
            "Please file any issues with the parser at https://github.com/indieweb/php-mf2/issues"
        ]
    }
}
gRegorLove added a commit to gRegorLove/php-mf2 that referenced this issue Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant