Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems with deletes when creating image when $HOME is a symlink #267

Closed
frankier opened this issue May 29, 2020 · 2 comments
Closed

Problems with deletes when creating image when $HOME is a symlink #267

frankier opened this issue May 29, 2020 · 2 comments
Labels
bug

Comments

@frankier
Copy link
Contributor

This is on a machine with a slightly odd set up. $HOME is set to /usr/homes/frr7/ , but /usr/homes/frr7 is just a symlink to /home/frr7 . If I apply #266 and try again:

~/.udocker/bin/udocker pull vitrivr/adampro:latest-selfcontained
~/.udocker/bin/udocker create --name=adampro vitrivr/adampro:latest-selfcontained

I get:

Error: delete outside of directory tree:  /usr/homes/frr7/.udocker/containers/3e756b95-fe2f-3d53-8e95-ef01a382adea/ROOT/etc/alternatives/pager.1.gz

The problem is that /usr/homes/frr7/ is always dereferenced when adding it to the safe prefixes, so only /home/frr7/.udocker/containers/ ends up as safe. The solution is to stop dereferencing symlinks so much.
@frankier frankier mentioned this issue May 29, 2020
Merged
@jorge-lip
Copy link
Collaborator

Checking of safe paths has been improved in devel and devel3 branches

@jorge-lip jorge-lip added the bug label May 13, 2021
@jorge-lip
Copy link
Collaborator

Addressed in v1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frankier @mariojmdavid @jorge-lip