You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Two of the observations were addresses successfully. The other two observations require refactoring. Nevertheless, the refactoring of those functions is not keeping all the functionalities and it's making the code less readable. At the moment the code will remain because it is not affecting its readability or functionality. If I find a new way to implement these changes I will code them in a future feature.
Reviewing the code I have found the following functions that can be improved following the "Best Practices" recommended for JS, HTML, and CSS:
In the following lines I am repeating myself. Maybe I can refactor my code to improve this code.
to-do-list-app/src/modules/create-li.js
Lines 23 to 32 in 46af879
Here, I can remove this comment because I have added the styling I wanted in a different way.
to-do-list-app/src/modules/create-li.js
Line 93 in 46af879
I am repeating the appendChild function a lot, and there should be a function to append multiple elements.
to-do-list-app/src/modules/create-li.js
Lines 51 to 55 in 46af879
I am repeating these functions for these elements.
to-do-list-app/src/modules/update-indexes.js
Lines 17 to 21 in 46af879
Despite all, most of my code follows the best practices in my opinion.
The text was updated successfully, but these errors were encountered: