Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build issue on astrolink4 with CircleCI #196

Closed
thx8411 opened this issue Aug 21, 2020 · 2 comments
Closed

Build issue on astrolink4 with CircleCI #196

thx8411 opened this issue Aug 21, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@thx8411
Copy link
Contributor

thx8411 commented Aug 21, 2020

Hi,

There is a build error on astrolink4 with CircleCI :

It's actually a warning, but "cc1plus: all warnings being treated as errors" kills the job.

<<
[ 12%] Building CXX object indi-astrolink4/CMakeFiles/indi_astrolink4.dir/indi_astrolink4.cpp.o
/root/project/indi-astrolink4/indi_astrolink4.cpp: In member function 'virtual IPState IndiAstrolink4::MoveAbsFocuser(uint32_t)':
/root/project/indi-astrolink4/indi_astrolink4.cpp:694:41: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
if((targetTicks + backlash) < 0 || (targetTicks + backlash) > FocusMaxPosN[0].value)
~~~~~~~~~~~~~~~~~~~~~~~~~^~~
cc1plus: all warnings being treated as errors
indi-astrolink4/CMakeFiles/indi_astrolink4.dir/build.make:62: recipe for target 'indi-astrolink4/CMakeFiles/indi_astrolink4.dir/indi_astrolink4.cpp.o' failed
make[2]: *** [indi-astrolink4/CMakeFiles/indi_astrolink4.dir/indi_astrolink4.cpp.o] Error 1
CMakeFiles/Makefile2:236: recipe for target 'indi-astrolink4/CMakeFiles/indi_astrolink4.dir/all' failed
make[1]: *** [indi-astrolink4/CMakeFiles/indi_astrolink4.dir/all] Error 2
Makefile:151: recipe for target 'all' failed
make: *** [all] Error 2

Best regards,

Blaise

@thx8411 thx8411 added the bug Something isn't working label Aug 21, 2020
@pawel-soja
Copy link
Contributor

Fixed in #299

@ggtux
Copy link

ggtux commented Feb 9, 2021 via email

@knro knro closed this as completed Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants