Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build issue on AHP driver with CircleCI #200

Closed
thx8411 opened this issue Aug 21, 2020 · 1 comment
Closed

Build issue on AHP driver with CircleCI #200

thx8411 opened this issue Aug 21, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@thx8411
Copy link
Contributor

thx8411 commented Aug 21, 2020

Hello,

There is a build issue on the AHP driver with CircleCI.
As usual, warnings treated as errors.

<<
Scanning dependencies of target indi_ahp_correlator

[100%] Building CXX object indi-ahp-correlator/CMakeFiles/indi_ahp_correlator.dir/indi_ahp_correlator.cpp.o

/root/project/indi-ahp-correlator/indi_ahp_correlator.cpp: In member function 'void Interferometer::Callback()':

/root/project/indi-ahp-correlator/indi_ahp_correlator.cpp:169:62: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]

         delay_clocks = (delay_clocks > 0 ? (delay_clocks < DELAY_LINES ? delay_clocks : DELAY_LINES-1) : 0);

                                             ~~~~~~~~~~~~~^~~~~~~~~~~~~

/root/project/indi-ahp-correlator/indi_ahp_correlator.cpp: In member function 'bool Interferometer::Handshake()':

/root/project/indi-ahp-correlator/indi_ahp_correlator.cpp:677:13: error: unused variable 'tmp' [-Werror=unused-variable]

     int tmp = 0;

         ^~~

cc1plus: all warnings being treated as errors

indi-ahp-correlator/CMakeFiles/indi_ahp_correlator.dir/build.make:62: recipe for target 'indi-ahp-correlator/CMakeFiles/indi_ahp_correlator.dir/indi_ahp_correlator.cpp.o' failed

make[2]: *** [indi-ahp-correlator/CMakeFiles/indi_ahp_correlator.dir/indi_ahp_correlator.cpp.o] Error 1

CMakeFiles/Makefile2:3017: recipe for target 'indi-ahp-correlator/CMakeFiles/indi_ahp_correlator.dir/all' failed

make[1]: *** [indi-ahp-correlator/CMakeFiles/indi_ahp_correlator.dir/all] Error 2

Makefile:151: recipe for target 'all' failed

make: *** [all] Error 2

Best regards,

Blaise

@thx8411 thx8411 added the bug Something isn't working label Aug 21, 2020
@pawel-soja
Copy link
Contributor

I think the problem is solved. @knro you can close issue.
I will make fixes for the warnings.

@knro knro closed this as completed Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants