Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle CI build is not working #3

Closed
knro opened this issue Sep 18, 2019 · 5 comments
Closed

Circle CI build is not working #3

knro opened this issue Sep 18, 2019 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@knro
Copy link
Collaborator

knro commented Sep 18, 2019

After the INDI Core and INDI 3rd party split, the Circle CI build scripts need to be revised to work. I revised them, but I'm not sure how to make the indi-3rdparty builds run against the latest libindi ?

@jochym
@eric-vickery

@thx8411
Copy link
Contributor

thx8411 commented Aug 21, 2020

Hello,

I don't really know what's wrong in the circleci config, but I did some tests, and I managed to get the previous sv305 driver
built on circleci (bionic target) with this config :

<<
build_bionic:
docker:
- image: jochym/indi-docker:bionic
steps:
- checkout
- run:
name: Build all
command: |
apt-get update
apt-get -y install apt-utils software-properties-common
apt-add-repository -y ppa:mutlaqja/indinightly
apt-get update
apt-get -y install libindi1 libindi-dev libcfitsio-dev zlib1g-dev
.circleci/build-core.sh
- run:
name: Run tests
command: .circleci/run-tests.sh

https://github.com/thx8411/indi-3rdparty/blob/master/.circleci/config.yml

All other drivers switched to "Off", to avoid other dependencies issues.

I hope it will help.

Best regards,

Blaise

@knro
Copy link
Collaborator Author

knro commented Aug 21, 2020

That's great to know! Can you please help us turn it on for all the drivers on each push event like the main repo?

@thx8411
Copy link
Contributor

thx8411 commented Aug 21, 2020

Hello,

I enabled all the drivers.
The issues had been reported as bugs (warnings treated as errors).
I didn't test GIGE, nor FXLOAD (already disabled).

I almost killed my CircleCI plan, but it's ok for the drivers left.

Screenshot from 2020-08-21 15-26-26

Attached my updated CircleCi file.
Dependencies checked.
Only enabled for bionic yet.

config.yml.txt

Best regards,

Blaise

@knro
Copy link
Collaborator Author

knro commented Aug 21, 2020

Can you submit this as a PR to be merged? The README still refers to the INDI CircleCI (Passed) so we must update that accordingly. As we find the warnings/errors, we'll fix them accordingly.

@pawel-soja
Copy link
Contributor

I think the problem is solved. @knro you can close issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants