Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meade DSI driver doesn not support Offset or Gain for DSI 1 and DSI 2 #374

Closed
astrogene1000 opened this issue Apr 10, 2021 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@astrogene1000
Copy link

Describe the bug
I am a user of both DSI 1 PRO and DSI 2 PRO and started to look into why I had not control over GAIN and Offset for an image

Seems for DSI 1 or 2 they are totally ignored and always set to 0 and 255 respectively in startExposure
status = command(DeviceCommand::SET_GAIN, 0);
// status = command(DeviceCommand::GET_READOUT_MODE);
status = command(DeviceCommand::SET_OFFSET, 0x0ff);

To Reproduce

  1. Run driver
  2. Try to set Offset or Gain with a DSI 1 or DSI 2
  3. See error

Expected behavior
Gain and offset controllable as per the offered settings in GUI

@astrogene1000 astrogene1000 added the bug Something isn't working label Apr 10, 2021
@astrogene1000
Copy link
Author

Created Draft PR under dev-version for fix
https://github.com/indilib/indi-3rdparty/pull/375

@astrogene1000
Copy link
Author

PR 374 merged! Thanks! Picked up >0.25mag deeper for the way I use the DSI's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant