Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moravian USB initialization issue #389

Closed
knro opened this issue May 2, 2021 · 3 comments
Closed

Moravian USB initialization issue #389

knro opened this issue May 2, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@knro
Copy link
Collaborator

knro commented May 2, 2021

After the changes in INDI v1.9.0, there is an issue when initializing Moravian USB cameras (didn't test Ethernet).

gxccd_initialize_usb(...) always returns nullptr. When switching back to using the ISXXX functions, the issue goes away and it returns a valid handle. I can't see what would be causing such an issue, since it's affecting the USB enumeration of the library. Is there some order of initialization that got messed up?

gxccd_enumerate_usb works fine in both versions and detects camera ID 30031.

@pawel-soja @sWski Any ideas on what's going on here?

@knro knro added the bug Something isn't working label May 2, 2021
@pawel-soja
Copy link
Contributor

One difference I can see is that gxccd_initialize_xxx is now called during gxccd_enumerate_xxx.
I will throw in a fix for testing.

@sWski
Copy link
Contributor

sWski commented May 3, 2021

Looking through the library code, it's not possible to call gxccd_initialize_usb() in gxccd_enumerate_usb(), as the library claims the interface with libusb and another libusb_open() fails because of that. @pawel-soja's fix should be sufficient. However there is no reason not to release the interface before calling the callback function, so I can fix this in next version.

@knro
Copy link
Collaborator Author

knro commented May 25, 2021

It's working now fine. Thanks @pawel-soja for the fix. Closing.

@knro knro closed this as completed May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants