Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored CAUX does not track in Az #510

Closed
jochym opened this issue Dec 28, 2021 · 1 comment
Closed

Refactored CAUX does not track in Az #510

jochym opened this issue Dec 28, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@jochym
Copy link
Contributor

jochym commented Dec 28, 2021

Bug:
Refactored indi-celestron-aux driver does not track in AZ.

@knro I do not know if you know about my testing PR (jochym#6) so I am posting a copy here. Where do you prefer to have feedback on your refactor work posted?

You have done a lot with the driver. However, It seems the driver is not tracking in Az. I have compiled the recent version (b3fddb4) - this is a first one I am testing, so I do not know if this is recent or not. See this log fragment:

org.kde.kstars.indi: Celestron AUX : "[ALIGNMENT] Axis1 encoder    4908650 -> AZ 105.3282° "
org.kde.kstars.indi: Celestron AUX : "[ALIGNMENT] Axis2 encoder    4170589 -> AL 89.4911° "
org.kde.kstars.indi: Celestron AUX : "[ALIGNMENT] Mount -> Sky RA: 21:28:52 DE: 50:51:46 AZ: 105:24:27 AL: 89:29:37 HA: 10:39:02 Pier: NA "
org.kde.kstars.indi: Celestron AUX : "[DEBUG] Tracking AZ Now: 4908650 Target: 12146708 Offset: 7238058 Rate: 100000.00 "
org.kde.kstars.indi: Celestron AUX : "[DEBUG] Tracking AZ P: 579044640.000000 I: 0.000000 D: -0.000000 "
org.kde.kstars.indi: Celestron AUX : "[DEBUG] Tracking AL Now: 4170589 Target: 4170608 Offset: 19 Rate: -480.00 "
org.kde.kstars.indi: Celestron AUX : "[DEBUG] Tracking AL P: 1520.000000 I: -2000.000000 D: -0.000000 "
org.kde.kstars.indi: Celestron AUX : "[CAUX] CMD <MC_SET_NEG_GUIDERATE>  APP ->  ALT [00 01 E0] "
org.kde.kstars.indi: Celestron AUX : "[CSER] CMD <3B 06 20 11 07 00 01 E0 E1> "
org.kde.kstars.indi: Celestron AUX : "[CSER] RES <3B 06 20 11 07 00 01 E0 E1> "
org.kde.kstars.indi: Celestron AUX : "[CAUX] RES <MC_SET_NEG_GUIDERATE>  APP ->  ALT [00 01 E0] "
org.kde.kstars.indi: Celestron AUX : "[CAUX] Got msg not for me (ALT). Ignoring. "
org.kde.kstars.indi: Celestron AUX : "[CSER] RES <3B 03 11 20 07 C5> "
org.kde.kstars.indi: Celestron AUX : "[CAUX] RES <MC_SET_NEG_GUIDERATE>  ALT ->  APP "
org.kde.kstars.indi: Celestron AUX : "[CAUX] CMD <MC_GET_POSITION>  APP ->  AZM "
org.kde.kstars.indi: Celestron AUX : "[CSER] CMD <3B 03 20 10 01 CC> "
org.kde.kstars.indi: Celestron AUX : "[CSER] RES <3B 03 20 10 01 CC> "
org.kde.kstars.indi: Celestron AUX : "[CAUX] RES <MC_GET_POSITION>  APP ->  AZM "
org.kde.kstars.indi: Celestron AUX : "[CAUX] Got msg not for me (AZM). Ignoring. "
org.kde.kstars.indi: Celestron AUX : "[CSER] RES <3B 06 10 20 01 4A EB DE B6> "
org.kde.kstars.indi: Celestron AUX : "[CAUX] RES <MC_GET_POSITION>  AZM ->  APP [4A EB DE] "
org.kde.kstars.indi: Celestron AUX : "[CAUX] CMD <MC_GET_POSITION>  APP ->  ALT "
org.kde.kstars.indi: Celestron AUX : "[CSER] CMD <3B 03 20 11 01 CB> "
org.kde.kstars.indi: Celestron AUX : "[CSER] RES <3B 03 20 11 01 CB> "
org.kde.kstars.indi: Celestron AUX : "[CAUX] RES <MC_GET_POSITION>  APP ->  ALT "
org.kde.kstars.indi: Celestron AUX : "[CAUX] Got msg not for me (ALT). Ignoring. "
org.kde.kstars.indi: Celestron AUX : "[CSER] RES <3B 06 11 20 01 3F A3 21 C5> "
org.kde.kstars.indi: Celestron AUX : "[CAUX] RES <MC_GET_POSITION>  ALT ->  APP [3F A3 21] "
org.kde.kstars.indi: Celestron AUX : "[ALIGNMENT] Axis1 encoder    4910046 -> AZ 105.3582° "
org.kde.kstars.indi: Celestron AUX : "[ALIGNMENT] Axis2 encoder    4170529 -> AL 89.4898° "
org.kde.kstars.indi: Celestron AUX : "[ALIGNMENT] Mount -> Sky RA: 21:28:54 DE: 50:51:44 AZ: 105:26:15 AL: 89:29:32 HA: 10:39:00 Pier: NA "
org.kde.kstars.indi: Celestron AUX : "[DEBUG] Tracking AZ Now: 4910046 Target: 12149334 Offset: 7239288 Rate: 100000.00 "
org.kde.kstars.indi: Celestron AUX : "[DEBUG] Tracking AZ P: 579143040.000000 I: 0.000000 D: -0.000000 "
org.kde.kstars.indi: Celestron AUX : "[DEBUG] Tracking AL Now: 4170529 Target: 4170475 Offset: -53 Rate: -6320.00 "
org.kde.kstars.indi: Celestron AUX : "[DEBUG] Tracking AL P: -4320.000000 I: -2000.000000 D: 0.000000 "
org.kde.kstars.indi: Celestron AUX : "[CAUX] CMD <MC_SET_NEG_GUIDERATE>  APP ->  ALT [00 18 B0] "
org.kde.kstars.indi: Celestron AUX : "[CSER] CMD <3B 06 20 11 07 00 18 B0 FA> "
org.kde.kstars.indi: Celestron AUX : "[CSER] RES <3B 06 20 11 07 00 18 B0 FA> "
org.kde.kstars.indi: Celestron AUX : "[CAUX] RES <MC_SET_NEG_GUIDERATE>  APP ->  ALT [00 18 B0] "
org.kde.kstars.indi: Celestron AUX : "[CAUX] Got msg not for me (ALT). Ignoring. "
org.kde.kstars.indi: Celestron AUX : "[CSER] RES <3B 03 11 20 07 C5> "
org.kde.kstars.indi: Celestron AUX : "[CAUX] RES <MC_SET_NEG_GUIDERATE>  ALT ->  APP "
org.kde.kstars.indi: Celestron AUX : "[CAUX] CMD <MC_GET_POSITION>  APP ->  AZM "
org.kde.kstars.indi: Celestron AUX : "[CSER] CMD <3B 03 20 10 01 CC> "
org.kde.kstars.indi: Celestron AUX : "[CSER] RES <3B 03 20 10 01 CC> "
org.kde.kstars.indi: Celestron AUX : "[CAUX] RES <MC_GET_POSITION>  APP ->  AZM "
org.kde.kstars.indi: Celestron AUX : "[CAUX] Got msg not for me (AZM). Ignoring. "
org.kde.kstars.indi: Celestron AUX : "[CSER] RES <3B 06 10 20 01 4A F1 51 3D> "
org.kde.kstars.indi: Celestron AUX : "[CAUX] RES <MC_GET_POSITION>  AZM ->  APP [4A F1 51] "
org.kde.kstars.indi: Celestron AUX : "[CAUX] CMD <MC_GET_POSITION>  APP ->  ALT "
org.kde.kstars.indi: Celestron AUX : "[CSER] CMD <3B 03 20 11 01 CB> "
org.kde.kstars.indi: Celestron AUX : "[CSER] RES <3B 03 20 11 01 CB> "
org.kde.kstars.indi: Celestron AUX : "[CAUX] RES <MC_GET_POSITION>  APP ->  ALT "
org.kde.kstars.indi: Celestron AUX : "[CAUX] Got msg not for me (ALT). Ignoring. "
org.kde.kstars.indi: Celestron AUX : "[CSER] RES <3B 06 11 20 01 3F A2 CD 1A> "
org.kde.kstars.indi: Celestron AUX : "[CAUX] RES <MC_GET_POSITION>  ALT ->  APP [3F A2 CD] "
org.kde.kstars.indi: Celestron AUX : "[ALIGNMENT] Axis1 encoder    4911441 -> AZ 105.3881° "
org.kde.kstars.indi: Celestron AUX : "[ALIGNMENT] Axis2 encoder    4170445 -> AL 89.4880° "
org.kde.kstars.indi: Celestron AUX : "[ALIGNMENT] Mount -> Sky RA: 21:28:56 DE: 50:51:42 AZ: 105:28:02 AL: 89:29:26 HA: 10:38:59 Pier: NA "
org.kde.kstars.indi: Celestron AUX : "[DEBUG] Tracking AZ Now: 4911441 Target: 12151931 Offset: 7240490 Rate: 100000.00 "
org.kde.kstars.indi: Celestron AUX : "[DEBUG] Tracking AZ P: 579239200.000000 I: 0.000000 D: -0.000000 "
org.kde.kstars.indi: Celestron AUX : "[DEBUG] Tracking AL Now: 4170445 Target: 4170342 Offset: -102 Rate: -10240.00 "
org.kde.kstars.indi: Celestron AUX : "[DEBUG] Tracking AL P: -8240.000000 I: -2000.000000 D: -0.000000 "

There are only ALT guide rate commands in the log and it was tracking object close to zenith. It should be tracking in Az like crazy... The code in tracking seems ok but i think the trackByRate may be skipping tracking i AZ due to detection of unchanged rate (just a suspicion).
I have also noted that you dropped slow-approach from the goto procedure. Both skysafari and hand controller software use this, so I presume it is beneficial. Do you intend to put it back in the future?

To Reproduce
I just compiled b3fddb4 against recent indi (from git/main) and run with recent kstars/ekos against real evo mount with CCD/GPS-sim.
After 4-point sync (simulated - no weather here) I tried to track at moderate alt and close to zenith (The zenith tends to show clearly errors in tracking). The pointing was adequate, but the tracking was missing Az commands.

Expected behavior
Good tracking.

Desktop (please complete the following information):

  • OS: Debian 11
  • Version git:b3fddb4

Log Files
See above fragment
@jochym jochym added the bug Something isn't working label Dec 28, 2021
@jochym jochym mentioned this issue Dec 28, 2021
Open
@jochym
Copy link
Contributor Author

jochym commented Dec 28, 2021

We are tracking this development here: jochym#6

@jochym jochym closed this as completed Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jochym