Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indi-aagcloudwatcher-ng : wrong data displayed in "Sensors" tab #546

Closed
aknotwot opened this issue Feb 15, 2022 · 1 comment
Closed

indi-aagcloudwatcher-ng : wrong data displayed in "Sensors" tab #546

aknotwot opened this issue Feb 15, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@aknotwot
Copy link
Contributor

in driver indi_aagcloudwatcher_ng, in "Sensors" tab of Indi Control Panel, the data seems organized wrongly.
One of the obvious issue is about "Ambient Temp. Sensor" and "Corrected Infrared Sky" which are mixed together.
After launching the driver, just need to check in the "Sensors" tab of Indi Control Panel. Data "Corrected Infrared Sky" is correctly displayed in Ekos "Weather" Tab.

But comparing data displayed in this "Sensors" tab between indi_aagcloudwatcher_ng and indi_aagcloudwatcher (cf screenshot, for the same Cloudwatcher device) at few seconds of interval, most of data seems mixed together, or even wrong as : "Rain Sensor (cycles)", "Rain Sensor Temperature (°c)", "Rain Sensor Heater (%)", "Brightness Sensor (K)"

Expected behavior
The "Corrected Infrared Sky" should display the data displayed on the label "Ambient Temp. Sensor", and the data of "Corrected Infrared Sky" should be displayed on label "Ambient Temp. Sensor".
Using the device specification and indi_aagcloudwater reference, the data displayed have to be coherent between two versions of the driver.

Desktop (please complete the following information):

  • OS: Ubuntu
  • indi_aagcloudwatcher_ng 1.6

Quick Analysis about "Ambient Temp. Sensor" and "Corrected Infrared Sky" :
Most of modification have to be done in file indi_aagcloudwatcher_ng.cpp, in function AAGCloudWatcher::sendData(), about "sensors" data :
for example we should have : about "Corrected Infrared Sky" nvpS->np[1].value = correctedTemperature; (after calculation of correctedTemperature )
and
about "Ambient Temp. Sensor" nvpS->np[7].value = float(data.sensor) / 100.0;

indi_aagcloudwatcher_ng_issue
comp__ng_vs_legacy

@aknotwot aknotwot added the bug Something isn't working label Feb 15, 2022
@aknotwot
Copy link
Contributor Author

aknotwot commented May 9, 2024

fixed in last version.

@aknotwot aknotwot closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant