Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EQMOD] Transient communication errors management #565

Closed
TallFurryMan opened this issue Apr 3, 2022 · 1 comment
Closed

[EQMOD] Transient communication errors management #565

TallFurryMan opened this issue Apr 3, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@TallFurryMan
Copy link
Contributor

TallFurryMan commented Apr 3, 2022 •
edited

Describe the bug
When using indi_eqmod_telescope, transient communication errors induce a large delay in controlling the mount.

To Reproduce

  1. I connect my HEQ5-Pro
  2. I issue a manual slew request at x800
  3. I stop the manual slew

Expected behavior
At step 3, movement stops immediately.

Actual behavior
At step 3, sometimes, the driver will apparently hang, INDI panel responsive but no actions executed, for 5 or 10 seconds.

Logs (below) show read error, will retry..., which tend to indicate a serial error while motors are running. I agree with that, as I am currently reworking the power supply of the mount, and I acknowledge a ground issue.

However, while the skywatcher code is retrying 100ms after the error, the default tty_read timeout is set to 5 seconds. This last delay is far too large to ensure secure recovery of the mount movement, especially in case of transient communication errors.

Logs

[2022-04-03T18:46:56.649 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":f1\", 4 bytes written "
[2022-04-03T18:46:56.659 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=711\", 5 bytes read "
[2022-04-03T18:46:56.660 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":f2\", 4 bytes written "
[2022-04-03T18:46:56.669 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=101\", 5 bytes read "
[2022-04-03T18:46:56.671 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[DEBUG] Scope RA (15:25:48) DE (90:00:00) Aligned RA (15:25:48) DE (90:00:00) AZ ( 0:00:00) ALT ( 0:00:00), PierSide (West) "
[2022-04-03T18:46:56.763 CEST INFO ][           org.kde.kstars.indi] - EQMod Mount :  "[INFO] East Slew stopped "
[2022-04-03T18:46:56.763 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[DEBUG] StopRA() : calling RA StopWaitMotor "
[2022-04-03T18:46:56.763 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":f1\", 4 bytes written "
[2022-04-03T18:46:56.773 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=711\", 5 bytes read "
[2022-04-03T18:46:56.774 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[MOUNT] StopWaitMotor() : Axis = 1 "
[2022-04-03T18:46:56.774 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":K1\", 4 bytes written "
[2022-04-03T18:47:01.776 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read error, will retry again... "
[2022-04-03T18:47:01.777 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":K1\", 4 bytes written "
[2022-04-03T18:47:01.782 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=\", 2 bytes read "
[2022-04-03T18:47:01.783 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":f1\", 4 bytes written "
[2022-04-03T18:47:01.794 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=711\", 5 bytes read "
[2022-04-03T18:47:01.894 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":f1\", 4 bytes written "
[2022-04-03T18:47:01.903 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=711\", 5 bytes read "
[2022-04-03T18:47:02.003 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":f1\", 4 bytes written "
[2022-04-03T18:47:02.014 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=711\", 5 bytes read "
[2022-04-03T18:47:02.115 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":f1\", 4 bytes written "
[2022-04-03T18:47:02.126 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=711\", 5 bytes read "
[2022-04-03T18:47:02.224 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":f1\", 4 bytes written "
[2022-04-03T18:47:02.234 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=711\", 5 bytes read "
[2022-04-03T18:47:02.335 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":f1\", 4 bytes written "
[2022-04-03T18:47:02.345 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=711\", 5 bytes read "
[2022-04-03T18:47:02.445 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":f1\", 4 bytes written "
[2022-04-03T18:47:02.456 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=711\", 5 bytes read "
[2022-04-03T18:47:02.557 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":f1\", 4 bytes written "
[2022-04-03T18:47:02.569 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=711\", 5 bytes read "
[2022-04-03T18:47:02.667 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":f1\", 4 bytes written "
[2022-04-03T18:47:02.677 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=711\", 5 bytes read "
[2022-04-03T18:47:02.778 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":f1\", 4 bytes written "
[2022-04-03T18:47:02.789 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=711\", 5 bytes read "
[2022-04-03T18:47:02.890 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":f1\", 4 bytes written "
[2022-04-03T18:47:02.901 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=711\", 5 bytes read "
[2022-04-03T18:47:03.002 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":f1\", 4 bytes written "
[2022-04-03T18:47:03.012 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=711\", 5 bytes read "
[2022-04-03T18:47:03.112 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":f1\", 4 bytes written "
[2022-04-03T18:47:03.124 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=301\", 5 bytes read "
[2022-04-03T18:47:03.125 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[SCOPE] Compute local time: lst=5.47004731 ( 5:28:12.17) - julian date=2459673.19932179 "
[2022-04-03T18:47:03.128 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":j1\", 4 bytes written "
[2022-04-03T18:47:03.138 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=530C62\", 8 bytes read "
[2022-04-03T18:47:03.139 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[SCOPE] GetRAEncoder() = 6425683 "
[2022-04-03T18:47:03.139 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":j2\", 4 bytes written "
[2022-04-03T18:47:03.150 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=806CA2\", 8 bytes read "
[2022-04-03T18:47:03.150 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[SCOPE] Current encoders RA=6425683 DE=10644608 "
[2022-04-03T18:47:03.151 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":f1\", 4 bytes written "
[2022-04-03T18:47:03.160 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] read_eqmod: \"=301\", 5 bytes read "
[2022-04-03T18:47:03.160 CEST DEBG ][           org.kde.kstars.indi] - EQMod Mount : "[COMM] dispatch_command: \":f2\", 4 bytes written "

Desktop (please complete the following information):

  • OS: Ubuntu 21.10
  • KStars 3.5.8, INDI 1.9.6-e0158b46, both built from git.
@TallFurryMan TallFurryMan added the bug Something isn't working label Apr 3, 2022
@TallFurryMan
Copy link
Contributor Author

Fixed by #568.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TallFurryMan