Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indi_sv305_ccd: Binning that the camera does not support can be selected. #663

Closed
jctk opened this issue Sep 23, 2022 · 8 comments
Closed
Labels
bug Something isn't working

Comments

@jctk
Copy link
Contributor

jctk commented Sep 23, 2022

Describe the bug
Binning that the camera does not support can be selected.

To Reproduce
Exact steps to reproduce the behavior.

  1. Connect SV905C
  2. Change binning to 3 in Ekos Camera module. SV905C supports only BINNING 1 and 2.
  3. I can select Binning 3 which the camera does not support. When the camera takes a picture, it does not generate an error and the FITS Header also records XBINNING 3 and YBINNING 3.

Expected behavior
Set the Binning choice in the INDI driver to the Binning supported by the camera during Camera Connect.

Screenshots
image

Desktop (please complete the following information):

  • OS: KStars on Windows 11, StellarMate OS 64bit on Raspberry 4B
  • INDI Version 1.9.7, KStars Version 3.6 Stable
@jctk jctk added the bug Something isn't working label Sep 23, 2022
@knro
Copy link
Collaborator

knro commented Sep 24, 2022

updateCCDBin in the driver can be updated to reject anything not 1 and 2.

@jctk
Copy link
Contributor Author

jctk commented Sep 24, 2022

Thanks
I'll check it later.

@knro
Copy link
Collaborator

knro commented Nov 16, 2022

Can you please check if the issue is resolved?

@jctk
Copy link
Contributor Author

jctk commented Nov 16, 2022

I cannot check this issue yet.
I have not yet started to fix this issue.

@jctk
Copy link
Contributor Author

jctk commented Nov 16, 2022

Could it be that INDI 1.9.9 is about to be released?
Should I hurry to fix this issue?

@knro
Copy link
Collaborator

knro commented Nov 16, 2022

INDI 1.9.9 is due Nov 30th so it would be great if this is resolved before then. Two weeks left.

@jctk
Copy link
Contributor Author

jctk commented Nov 16, 2022

Okay, I'll give it a try. Please wait for me.

@jctk
Copy link
Contributor Author

jctk commented Nov 16, 2022

I set out to fix it and found that this is not a bug.

The SVBONY CCD INDI driver uses INDI's software binning.
In other words, it is not limited by the binning supported by the camera.
Therefore, this issue is not a problem that needs to be fixed in a hurry.

I would consider rewriting the driver using the SVBONY Camera SDK binning mechanism after the release of INDI 1.9.9. I do not fully understand the INDI mechanism for binning.

@knro knro closed this as completed Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants