Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Issues #876

Closed
nikodemusP opened this issue Dec 25, 2023 · 1 comment
Closed

Build Issues #876

nikodemusP opened this issue Dec 25, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@nikodemusP
Copy link

nikodemusP commented Dec 25, 2023

Describe the bug
There are several build-issues within the CMakefiles

  • cmake_minimum_required should be upgraded at least 3.5 or higher => avoid of Warnings
  • exec_program is deprecated => should be changed to execute_process

i.e.

CMake Warning (dev) at indi-gphoto/make_gphoto_symlink.cmake:1 (exec_program):
Policy CMP0153 is not set: The exec_program command should not be called.
Run "cmake --help-policy CMP0153" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.

Use execute_process() instead.
Call Stack (most recent call first):
indi-gphoto/cmake_install.cmake:86 (include)
cmake_install.cmake:48 (include)
This warning is for project developers. Use -Wno-dev to suppress it.

  • TOUPBASE requires libmeadecam, but is not build within the "lib"

--- a/CMakeLists.txt 2023-12-25 16:48:59.734605816 +0100
+++ b/CMakeLists.txt 2023-12-25 17:03:34.432832655 +0100
@@ -357,6 +357,7 @@
add_subdirectory(libmallincam)
add_subdirectory(libomegonprocam)
add_subdirectory(libtscam)
+add_subdirectory(libmeadecam)
endif (WITH_TOUPBASE)

To Reproduce
a) Build the libraries with CMake 3.28
b) Build the driver

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS: Arch-Linux
  • Version 6.6
  • CMake 3.28

Log Files

@nikodemusP nikodemusP added the bug Something isn't working label Dec 25, 2023
@knro
Copy link
Collaborator

knro commented Jan 23, 2024

This is resolved in master, please try again.

@knro knro closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants