Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indi_vantage driver don't update last 4 properties #743

Closed
mmastria opened this issue Oct 27, 2018 · 2 comments
Closed

indi_vantage driver don't update last 4 properties #743

mmastria opened this issue Oct 27, 2018 · 2 comments

Comments

@mmastria
Copy link
Contributor

mmastria commented Oct 27, 2018

This was discussed in forum:
https://www.indilib.org/forum/general/3407-vantage-pro-2-driver.html

I'm starting using this driver and verified that there's some bugs.
I corrected them and it's working on my observatory.

There's something else that I don't agree, but I'll make a new ticket as improvement ater bug corrections. It's about the use of internal temperature/humidity. There's no reason to use internal information, better using external temperature/humidity, as the telescope will be exposed to external conditions, and normally the receiver console (where the "internal" information is read) isn't in the same room, so this internal information have no real importance. But as I said, I'll put this in discussion in another ticket to not mix bug corrections with feature behaviour.

I'll create a branch to correct the bugs and a pull request on this.

DIff Code:

129c129
old: addParameter("WEAHTER_WIND_DIRECTION", "Wind Direction", 0, 360, 15);
new: addParameter("WEATHER_WIND_DIRECTION", "Wind Direction", 0, 360, 15);

268a269,275
new: // Inside Humidity
new: uint8_t humidityValue = loopData[11];
new:
new: setParameterValue("WEATHER_HUMIDITY", humidityValue );
new:
new: LOGF_DEBUG("Raw Inside Humidity (%d) [%#X4]", humidityValue, loopData[11]);

279c286
old: LOGF_DEBUG("Raw Wind Speed (%d) [%#X4]", windValue, loopData[14]);
new: LOGF_DEBUG("Raw Wind Speed (%d) [%#4X]", windValue, loopData[14]);

@mmastria
Copy link
Contributor Author

pull request:
#745

@knro
Copy link
Contributor

knro commented Oct 28, 2018

Thanks! merged.

@knro knro closed this as completed Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants