New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Allow upgrade to Django 2.0 #422
Conversation
@dzhuang I'll wait with this until you have a chance to test it/give the go-ahead. |
The unicode fixes in ce58e1b are probably worth having no matter what. |
Heh. Kind of forgot about the biggest part of this. Django 2.0 is Py3 only. Personally, I've been on Py3 in production for a while, and I'm ready to let Py2 go. Either way, we would need some CI engineering. How about you? |
Got it. |
@inducer Can you merge master into this? Thanks. |
Done. |
Can you review this? Thanks. inducer/django-bootstrap3-datetimepicker#7 |
Done. |
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
==========================================
- Coverage 72.9% 72.89% -0.01%
==========================================
Files 45 45
Lines 11126 11128 +2
Branches 2069 2069
==========================================
+ Hits 8111 8112 +1
- Misses 2497 2499 +2
+ Partials 518 517 -1
Continue to review full report at Codecov.
|
d501a29
to
3c0900e
Compare
@dzhuang How do you feel about this? I'd prefer to get this in this weekend. For now, we're just allowing Django 2, so it doesn't rule out Py2 just yet. Plus my Celery is slightly broken in production, and I'd like to only re-debug it once. (rather than twice--now and again when we hop to Celery 4.) |
I no longer believe that's true. Py2 will just select Django 1.11 automatically. |
I'm ok with this, but the docs were not ready yet. Sorry for late response (until I finally found a way to access my gmail). |
@dzhuang I'm using this brach to also switch to pipenv (which I seem to rather like for predictable deployment). Could you give this a try and see what you think? |
You can merge it once you think it's ready (I won't have time to test this in a couple of hours). I'll complain if it failed for me. :) |
OK, thanks! I'll at least make sure I keep the CIs working. |
Wow, seriously, forget Pipenv. What a waste of time. |
I see there is a long que in appveyor ci (due to hang of previously failed build). I think you can manually cancel those build to see whether the latest build works. |
In it goes. |
Finally, thanks. Let's wait and see :) |
cc @dzhuang
Also jump onto new version of Celery.
Things to resolve: