-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluid dimensions validation is missing #19
Comments
|
Have you tried the most recent version of |
I assumed that as I started the notebook in a colab, it would installed the latest version. When I try to add particle radius it says it doesn't have that variable on init. |
@begaiym-k @luispcunha can you have a look please? |
I also tried... It might be that we need to ignore some cached things with pip install and enforce that it gets the latest version from the git repo... not sure... |
It doesn't work because in Ivan's notebook a different branch is installed not a main branch. @IvanPombo , @hpenedones you will have to install the latest version from the main branch and maybe add |
Is this issue solved? @begaiym-k @IvanPombo |
Yes! |
Playing with the API, I have noticed that we can insert non-positive values to the fluid_dimensions which does not make sense.
The text was updated successfully, but these errors were encountered: