Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluid dimensions validation is missing #19

Closed
IvanPombo opened this issue Feb 20, 2023 · 8 comments
Closed

Fluid dimensions validation is missing #19

IvanPombo opened this issue Feb 20, 2023 · 8 comments
Assignees

Comments

@IvanPombo
Copy link
Contributor

Playing with the API, I have noticed that we can insert non-positive values to the fluid_dimensions which does not make sense.

  • Fluid dimensions need to be positive and bigger than the particle radius.
@begaiym-k begaiym-k self-assigned this Feb 20, 2023
@IvanPombo
Copy link
Contributor Author

  • The update for particle radius is not yet on the client side. I cannot play with it.

@fabiocruz
Copy link
Contributor

  • The update for particle radius is not yet on the client side. I cannot play with it.

Have you tried the most recent version of main? This was included by @begaiym-k in this PR last week.

@IvanPombo
Copy link
Contributor Author

  • The update for particle radius is not yet on the client side. I cannot play with it.

Have you tried the most recent version of main? This was included by @begaiym-k in this PR last week.

I assumed that as I started the notebook in a colab, it would installed the latest version. When I try to add particle radius it says it doesn't have that variable on init.

@fabiocruz
Copy link
Contributor

  • The update for particle radius is not yet on the client side. I cannot play with it.

Have you tried the most recent version of main? This was included by @begaiym-k in this PR last week.

I assumed that as I started the notebook in a colab, it would installed the latest version. When I try to add particle radius it says it doesn't have that variable on init.

@begaiym-k @luispcunha can you have a look please?

@hpenedones
Copy link
Contributor

I also tried... It might be that we need to ignore some cached things with pip install and enforce that it gets the latest version from the git repo... not sure...

@begaiym-k
Copy link
Contributor

It doesn't work because in Ivan's notebook a different branch is installed not a main branch. @IvanPombo , @hpenedones you will have to install the latest version from the main branch and maybe add --no-cache-dir while installing it.

@luispcunha
Copy link
Contributor

Is this issue solved? @begaiym-k @IvanPombo

@begaiym-k
Copy link
Contributor

Yes!

@hpenedones hpenedones changed the title Bugs on API - SPH Fluid dimensions validation is missing Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants