Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplishSplash and DualSPH for the dam break scenario #42

Closed
sarmento opened this issue Feb 28, 2023 · 0 comments · Fixed by #77
Closed

SplishSplash and DualSPH for the dam break scenario #42

sarmento opened this issue Feb 28, 2023 · 0 comments · Fixed by #77
Assignees
Labels
enhancement New feature or request Urgent We need to look at this ASAP

Comments

@sarmento
Copy link
Contributor

sarmento commented Feb 28, 2023

As a user of the current dam break demo, I have the need to show investors that it is possible to seamlessly change the underlying simulator without changing anything else on my code, except the simulator parameter. This is a major selling point of the API because it allows us to show we are not stuck to a specific provider of simulation (and so we are not in a fragile business position that we depend on a single point to expose a certain functionality). I need to be able to show we can do this:

sim_output = scenario.simulate()

which runs with some default simulator (and which the user doesn't have to select but we will inform the user via a status message), but also:

sim_output = scenario.simulate(engine="splishsplash", device="gpu")

or

sim_output = scenario.simulate(engine="dualsphysics", device="cpu")

the feedback messages should show that we are running with these options, and the output should be syntactically the same so that the rest of the code does not change.

This is an urgent feature since it allows us to show a very important aspect of the API

Note: I would like this to be implemented by Luis+Begaiym with only distant supervision from Fabio.

@sarmento sarmento added enhancement New feature or request Urgent We need to look at this ASAP labels Feb 28, 2023
@hpenedones hpenedones changed the title I want to be able to swap between SplishSplash and DualSPH for the dam break scenario swap between SplishSplash and DualSPH for the dam break scenario Feb 28, 2023
@hpenedones hpenedones changed the title swap between SplishSplash and DualSPH for the dam break scenario SplishSplash and DualSPH for the dam break scenario Feb 28, 2023
@begaiym-k begaiym-k linked a pull request Mar 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Urgent We need to look at this ASAP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants